Show currently active key in settings #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 2f4d811 in 34 seconds
More details
- Looked at
35lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_EvI7Xxom8ggcWhm6
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| <CardDescription>Currently active API key</CardDescription> | ||
| </CardHeader> | ||
| <CardContent className="p-8"> | ||
| <HiddenCopyableInput value={apiKey ?? "API key not found"} /> |
There was a problem hiding this comment.
Displaying sensitive information such as API keys in the UI can pose a security risk. Ensure that this feature includes adequate access controls and security measures to protect the API key from unauthorized access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added a new card to display the currently active API key in the
Settingscomponent.Key points:
skyvern-frontend/src/routes/settings/Settings.tsx.envCredentialfrom@/util/envto fetch the API key.HiddenCopyableInputcomponent to display the API key.Settingscomponent to include the new card for the API key.Generated with ❤️ by ellipsis.dev